Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor havener pkg #626

Merged
merged 6 commits into from
May 15, 2024
Merged

Refactor havener pkg #626

merged 6 commits into from
May 15, 2024

Conversation

HeavyWombat
Copy link
Member

@HeavyWombat HeavyWombat commented May 15, 2024 •
edited
Loading

  • Refactor PurgePod to pointer receiver
  • Use handle context in calls
  • Refactor node-exec to use program context
  • Include cluster name in verbose output
  • Simplify code by reusing existing list function
  • Tweak node exec setup

@HeavyWombat
Refactor PurgePod to pointer receiver
cd2d604 
Change `PurgePod` to be pointer receiver of `Hnvr`.
@HeavyWombat
Use handle context in calls
f1a8253 
Use context stored in main handle in Kubernetes calls.
@HeavyWombat
Refactor node-exec to use program context
ada8fc6 
Switch to context provided by Havener handle.

Remove deprecated function.
@HeavyWombat
Include cluster name in verbose output
46ec4ff 
Add cluster name to verbose output of Kubernetes configuration.
@HeavyWombat
Simplify code by reusing existing list function
dd4a22c 
Use existing list functions to get all nodes.
@HeavyWombat
Tweak node exec setup
2f73350 
Improve verbose output for command.

Improve `PodSpec` setup.
@HeavyWombat HeavyWombat changed the title refactor/havener pkg Refactor havener pkg May 15, 2024
@HeavyWombat HeavyWombat merged commit 405d2b4 into main May 15, 2024
8 checks passed
@HeavyWombat HeavyWombat deleted the refactor/havener-pkg branch May 15, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HeavyWombat